andry/EMS-ESP32
1
0
Fork 0
mirror of https://github.com/emsesp/EMS-ESP32.git synced 2026-09-13 21:54:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix firmware size check

Browse Source
This commit is contained in:
proddy
2026-08-03 09:59:46 +02:00
parent ba0f4cd008
commit 02caaef916
1 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/core/system.cpp
+11 -5
View File
@@ -3024,18 +3024,24 @@ bool System::uploadFirmwareURL(const char * url) {
return false; // error return false; // error
} }
// the Content-Length from the response header, -1 if the server didn't send one.
int firmware_size = http.getSize(); int firmware_size = http.getSize();
if (firmware_size <= 0) {
LOG_ERROR("Firmware upload failed - unknown size");
http.end();
return false; // error
}
// check we have a valid size // catch a wrong URL early, before streaming. Smallest shipped image is ~1.9MB
if (firmware_size < 2097152) { // 2MB or greater is required if (firmware_size < 1677721) { // 1.6MB
LOG_ERROR("Firmware upload failed - invalid size"); LOG_ERROR("Firmware upload failed - too small (%d KB)", firmware_size / 1024);
http.end(); http.end();
return false; // error return false; // error
} }
// check we have enough space for the upload in the ota partition // check we have enough space for the upload in the ota partition
if (!Update.begin(firmware_size)) { if (!Update.begin(firmware_size)) {
LOG_ERROR("Firmware upload failed - no space"); LOG_ERROR("Firmware upload failed - %s", Update.errorString());
http.end(); http.end();
return false; // error return false; // error
} }
@@ -3052,7 +3058,7 @@ bool System::uploadFirmwareURL(const char * url) {
// get tcp stream and send it to Updater // get tcp stream and send it to Updater
WiFiClient * stream = http.getStreamPtr(); WiFiClient * stream = http.getStreamPtr();
if (Update.writeStream(*stream) != firmware_size) { if (Update.writeStream(*stream) != (size_t)firmware_size) {
LOG_ERROR("Firmware upload failed - size differences"); LOG_ERROR("Firmware upload failed - size differences");
http.end(); http.end();
EMSESP::system_.systemStatus(SYSTEM_STATUS::SYSTEM_STATUS_ERROR_UPLOAD); EMSESP::system_.systemStatus(SYSTEM_STATUS::SYSTEM_STATUS_ERROR_UPLOAD);