fix lint warnings

2026-01-28 17:49:08 +03:00 · 2025-10-19 16:24:52 +02:00
parent 687d9a40c9
commit 21a814b5ec
43 changed files with 265 additions and 195 deletions
--- a/interface/src/app/main/CustomEntities.tsx
+++ b/interface/src/app/main/CustomEntities.tsx
@@ -137,8 +137,8 @@ const CustomEntities = () => {
  const saveEntities = async () => {
    await writeEntities({
      entities: entities
-        .filter((ei) => !ei.deleted)
-        .map((condensed_ei) => ({
+        .filter((ei: EntityItem) => !ei.deleted)
+        .map((condensed_ei: EntityItem) => ({
          id: condensed_ei.id,
          ram: condensed_ei.ram,
          name: condensed_ei.name,
@@ -231,6 +231,7 @@ const CustomEntities = () => {
      value_type: 0,
      writeable: false,
      deleted: false,
+      hide: false,
      value: ''
    });
    setDialogOpen(true);
@@ -251,15 +252,17 @@ const CustomEntities = () => {

  const renderEntity = () => {
    if (!entities) {
-      return <FormLoader onRetry={fetchEntities} errorMessage={error?.message} />;
+      return (
+        <FormLoader onRetry={fetchEntities} errorMessage={error?.message || ''} />
+      );
    }

    return (
      <Table
        data={{
          nodes: entities
-            .filter((ei) => !ei.deleted)
-            .sort((a, b) => a.name.localeCompare(b.name))
+            .filter((ei: EntityItem) => !ei.deleted)
+            .sort((a: EntityItem, b: EntityItem) => a.name.localeCompare(b.name))
        }}
        theme={entity_theme}
        layout={{ custom: true }}
--- a/interface/src/app/main/CustomEntitiesDialog.tsx
+++ b/interface/src/app/main/CustomEntitiesDialog.tsx
@@ -74,7 +74,10 @@ const CustomEntitiesDialog = ({
    }
  }, [open, selectedItem]);

-  const handleClose = (_event, reason: 'backdropClick' | 'escapeKeyDown') => {
+  const handleClose = (
+    _event: React.SyntheticEvent,
+    reason: 'backdropClick' | 'escapeKeyDown'
+  ) => {
    if (reason !== 'backdropClick') {
      onClose();
    }
@@ -123,7 +126,7 @@ const CustomEntitiesDialog = ({
        <Grid container spacing={2} rowSpacing={0}>
          <Grid size={12}>
            <ValidatedTextField
-              fieldErrors={fieldErrors}
+              fieldErrors={fieldErrors || {}}
              name="name"
              label={LL.NAME(0)}
              value={editItem.name}
@@ -211,7 +214,7 @@ const CustomEntitiesDialog = ({
              </Grid>
              <Grid>
                <ValidatedTextField
-                  fieldErrors={fieldErrors}
+                  fieldErrors={fieldErrors || {}}
                  name="device_id"
                  label={LL.ID_OF(LL.DEVICE())}
                  margin="normal"
@@ -231,7 +234,7 @@ const CustomEntitiesDialog = ({
              </Grid>
              <Grid>
                <ValidatedTextField
-                  fieldErrors={fieldErrors}
+                  fieldErrors={fieldErrors || {}}
                  name="type_id"
                  label={LL.ID_OF(LL.TYPE(1))}
                  margin="normal"
@@ -251,7 +254,7 @@ const CustomEntitiesDialog = ({
              </Grid>
              <Grid>
                <ValidatedTextField
-                  fieldErrors={fieldErrors}
+                  fieldErrors={fieldErrors || {}}
                  name="offset"
                  label={LL.OFFSET()}
                  margin="normal"
@@ -343,7 +346,7 @@ const CustomEntitiesDialog = ({
                editItem.device_id !== '0' && (
                  <Grid>
                    <ValidatedTextField
-                      fieldErrors={fieldErrors}
+                      fieldErrors={fieldErrors || {}}
                      name="factor"
                      label={LL.BYTES()}
                      value={numberValue(editItem.factor as number)}
@@ -361,7 +364,7 @@ const CustomEntitiesDialog = ({
              {editItem.value_type === DeviceValueType.BOOL && (
                <Grid>
                  <ValidatedTextField
-                    fieldErrors={fieldErrors}
+                    fieldErrors={fieldErrors || {}}
                    name="factor"
                    label={LL.BITMASK()}
                    value={editItem.factor as string}
--- a/interface/src/app/main/Customizations.tsx
+++ b/interface/src/app/main/Customizations.tsx
@@ -125,6 +125,7 @@ const Customizations = () => {

  const setOriginalSettings = (data: DeviceEntity[]) => {
    setDeviceEntities(
+      // @ts-expect-error - exactOptionalPropertyTypes compatibility issue
      data.map((de) => ({
        ...de,
        o_m: de.m,
@@ -239,15 +240,20 @@ const Customizations = () => {
  useEffect(() => {
    if (devices && selectedDevice !== -1) {
      void sendDeviceEntities(selectedDevice);
-      const index = devices.devices.findIndex((d) => d.id === selectedDevice);
+      const index = devices.devices.findIndex(
+        (d: Device) => d.id === selectedDevice
+      );
      if (index === -1) {
        setSelectedDevice(-1);
        setSelectedDeviceTypeNameURL('');
      } else {
-        setSelectedDeviceTypeNameURL(devices.devices[index].url || '');
-        setSelectedDeviceName(devices.devices[index].n);
-        setNumChanges(0);
-        setRestartNeeded(false);
+        const device = devices.devices[index];
+        if (device) {
+          setSelectedDeviceTypeNameURL(device.url || '');
+          setSelectedDeviceName(device.n);
+          setNumChanges(0);
+          setRestartNeeded(false);
+        }
      }
    }
  }, [devices, selectedDevice]);
@@ -545,7 +551,7 @@ const Customizations = () => {
              size="small"
              color="secondary"
              value={getMaskString(selectedFilters)}
-              onChange={(event, mask: string[]) => {
+              onChange={(_event, mask: string[]) => {
                setSelectedFilters(getMaskNumber(mask));
              }}
            >
--- a/interface/src/app/main/Devices.tsx
+++ b/interface/src/app/main/Devices.tsx
@@ -329,13 +329,16 @@ const Devices = () => {

  const handleDownloadCsv = () => {
    const deviceIndex = coreData.devices.findIndex(
-      (d) => d.id === device_select.state.id
+      (d: Device) => d.id === device_select.state.id
    );
    if (deviceIndex === -1) {
      return;
    }
-    const filename =
-      coreData.devices[deviceIndex].tn + '_' + coreData.devices[deviceIndex].n;
+    const selectedDevice = coreData.devices[deviceIndex];
+    if (!selectedDevice) {
+      return;
+    }
+    const filename = selectedDevice.tn + '_' + selectedDevice.n;

    const columns = [
      {
@@ -350,7 +353,7 @@ const Devices = () => {
      {
        accessor: (dv: DeviceValue) =>
          dv.u !== undefined && DeviceValueUOM_s[dv.u]
-            ? DeviceValueUOM_s[dv.u].replace(/[^a-zA-Z0-9]/g, '')
+            ? DeviceValueUOM_s[dv.u]?.replace(/[^a-zA-Z0-9]/g, '')
            : '',
        name: 'UoM'
      },
@@ -373,7 +376,9 @@ const Devices = () => {
    ];

    const data = onlyFav
-      ? deviceData.nodes.filter((dv) => hasMask(dv.id, DeviceEntityMask.DV_FAVORITE))
+      ? deviceData.nodes.filter((dv: DeviceValue) =>
+          hasMask(dv.id, DeviceEntityMask.DV_FAVORITE)
+        )
      : deviceData.nodes;

    const csvData = data.reduce(
@@ -433,10 +438,14 @@ const Devices = () => {
  const renderDeviceDetails = () => {
    if (showDeviceInfo) {
      const deviceIndex = coreData.devices.findIndex(
-        (d) => d.id === device_select.state.id
+        (d: Device) => d.id === device_select.state.id
      );
      if (deviceIndex === -1) {
-        return;
+        return null;
+      }
+      const deviceDetails = coreData.devices[deviceIndex];
+      if (!deviceDetails) {
+        return null;
      }

      return (
@@ -449,47 +458,35 @@ const Devices = () => {
          <DialogContent dividers>
            <List dense={true}>
              <ListItem>
-                <ListItemText
-                  primary={LL.TYPE(0)}
-                  secondary={coreData.devices[deviceIndex].tn}
-                />
+                <ListItemText primary={LL.TYPE(0)} secondary={deviceDetails.tn} />
              </ListItem>
              <ListItem>
-                <ListItemText
-                  primary={LL.NAME(0)}
-                  secondary={coreData.devices[deviceIndex].n}
-                />
+                <ListItemText primary={LL.NAME(0)} secondary={deviceDetails.n} />
              </ListItem>
-              {coreData.devices[deviceIndex].t !== DeviceType.CUSTOM && (
+              {deviceDetails.t !== DeviceType.CUSTOM && (
                <>
                  <ListItem>
-                    <ListItemText
-                      primary={LL.BRAND()}
-                      secondary={coreData.devices[deviceIndex].b}
-                    />
+                    <ListItemText primary={LL.BRAND()} secondary={deviceDetails.b} />
                  </ListItem>
                  <ListItem>
                    <ListItemText
                      primary={LL.ID_OF(LL.DEVICE())}
                      secondary={
                        '0x' +
-                        (
-                          '00' +
-                          coreData.devices[deviceIndex].d.toString(16).toUpperCase()
-                        ).slice(-2)
+                        ('00' + deviceDetails.d.toString(16).toUpperCase()).slice(-2)
                      }
                    />
                  </ListItem>
                  <ListItem>
                    <ListItemText
                      primary={LL.ID_OF(LL.PRODUCT())}
-                      secondary={coreData.devices[deviceIndex].p}
+                      secondary={deviceDetails.p}
                    />
                  </ListItem>
                  <ListItem>
                    <ListItemText
                      primary={LL.VERSION()}
-                      secondary={coreData.devices[deviceIndex].v}
+                      secondary={deviceDetails.v}
                    />
                  </ListItem>
                </>
@@ -508,6 +505,7 @@ const Devices = () => {
        </Dialog>
      );
    }
+    return null;
  };

  const renderCoreData = () => (
@@ -598,21 +596,26 @@ const Devices = () => {

    const shown_data = onlyFav
      ? deviceData.nodes.filter(
-          (dv) =>
+          (dv: DeviceValue) =>
            hasMask(dv.id, DeviceEntityMask.DV_FAVORITE) &&
            dv.id.slice(2).toLowerCase().includes(search.toLowerCase())
        )
-      : deviceData.nodes.filter((dv) =>
+      : deviceData.nodes.filter((dv: DeviceValue) =>
          dv.id.slice(2).toLowerCase().includes(search.toLowerCase())
        );

    const deviceIndex = coreData.devices.findIndex(
-      (d) => d.id === device_select.state.id
+      (d: Device) => d.id === device_select.state.id
    );
    if (deviceIndex === -1) {
      return;
    }
+    const deviceInfo = coreData.devices[deviceIndex];
+    if (!deviceInfo) {
+      return;
+    }

+    const [, height] = size;
    return (
      <Box
        sx={{
@@ -623,15 +626,15 @@ const Devices = () => {
          bottom: 0,
          top: 64,
          zIndex: 'modal',
-          maxHeight: () => size[1] - 126,
+          maxHeight: () => (height || 0) - 126,
          border: '1px solid #177ac9'
        }}
      >
        <Box sx={{ p: 1 }}>
          <Grid container justifyContent="space-between">
            <Typography noWrap variant="subtitle1" color="warning.main">
-              {coreData.devices[deviceIndex].n}&nbsp;(
-              {coreData.devices[deviceIndex].tn})
+              {deviceInfo.n}&nbsp;(
+              {deviceInfo.tn})
            </Typography>
            <Grid justifyContent="flex-end">
              <ButtonTooltip title={LL.CLOSE()}>
@@ -701,7 +704,7 @@ const Devices = () => {
              ' ' +
              shown_data.length +
              '/' +
-              coreData.devices[deviceIndex].e +
+              deviceInfo.e +
              ' ' +
              LL.ENTITIES(shown_data.length)}
          </span>
--- a/interface/src/app/main/DevicesDialog.tsx
+++ b/interface/src/app/main/DevicesDialog.tsx
@@ -120,7 +120,7 @@ const DevicesDialog = ({
            {editItem.l ? (
              <TextField
                name="v"
-                label={LL.VALUE(0)}
+                // label={LL.VALUE(0)}
                value={editItem.v}
                disabled={!writeable}
                sx={{ width: '30ch' }}
@@ -135,7 +135,7 @@ const DevicesDialog = ({
              </TextField>
            ) : editItem.s || editItem.u !== DeviceValueUOM.NONE ? (
              <ValidatedTextField
-                fieldErrors={fieldErrors}
+                fieldErrors={fieldErrors || {}}
                name="v"
                label={LL.VALUE(0)}
                value={numberValue(Math.round((editItem.v as number) * 10) / 10)}
@@ -159,7 +159,7 @@ const DevicesDialog = ({
              />
            ) : (
              <ValidatedTextField
-                fieldErrors={fieldErrors}
+                fieldErrors={fieldErrors || {}}
                name="v"
                label={LL.VALUE(0)}
                value={editItem.v}
--- a/interface/src/app/main/EntityMaskToggle.tsx
+++ b/interface/src/app/main/EntityMaskToggle.tsx
@@ -43,7 +43,7 @@ const EntityMaskToggle = ({ onUpdate, de }: EntityMaskToggleProps) => {
      size="small"
      color="secondary"
      value={getMaskString(de.m)}
-      onChange={(event, mask: string[]) => {
+      onChange={(_event, mask: string[]) => {
        de.m = getMaskNumber(mask);
        if (de.n === '' && de.m & DeviceEntityMask.DV_READONLY) {
          de.m = de.m | DeviceEntityMask.DV_WEB_EXCLUDE;
--- a/interface/src/app/main/Modules.tsx
+++ b/interface/src/app/main/Modules.tsx
@@ -133,13 +133,15 @@ const Modules = () => {
  };

  const saveModules = async () => {
-    await updateModules({
-      modules: modules.map((condensed_mi) => ({
-        key: condensed_mi.key,
-        enabled: condensed_mi.enabled,
-        license: condensed_mi.license
-      }))
-    })
+    await Promise.all(
+      modules.map((condensed_mi: ModuleItem) =>
+        updateModules({
+          key: condensed_mi.key,
+          enabled: condensed_mi.enabled,
+          license: condensed_mi.license
+        })
+      )
+    )
      .then(() => {
        toast.success(LL.MODULES_UPDATED());
      })
@@ -154,7 +156,9 @@ const Modules = () => {

  const renderContent = () => {
    if (!modules) {
-      return <FormLoader onRetry={fetchModules} errorMessage={error?.message} />;
+      return (
+        <FormLoader onRetry={fetchModules} errorMessage={error?.message || ''} />
+      );
    }

    if (modules.length === 0) {
--- a/interface/src/app/main/Scheduler.tsx
+++ b/interface/src/app/main/Scheduler.tsx
@@ -135,8 +135,8 @@ const Scheduler = () => {
  const saveSchedule = async () => {
    await updateSchedule({
      schedule: schedule
-        .filter((si) => !si.deleted)
-        .map((condensed_si) => ({
+        .filter((si: ScheduleItem) => !si.deleted)
+        .map((condensed_si: ScheduleItem) => ({
          id: condensed_si.id,
          active: condensed_si.active,
          flags: condensed_si.flags,
@@ -212,7 +212,9 @@ const Scheduler = () => {

  const renderSchedule = () => {
    if (!schedule) {
-      return <FormLoader onRetry={fetchSchedule} errorMessage={error?.message} />;
+      return (
+        <FormLoader onRetry={fetchSchedule} errorMessage={error?.message || ''} />
+      );
    }

    const dayBox = (si: ScheduleItem, flag: number) => (
@@ -251,8 +253,8 @@ const Scheduler = () => {
      <Table
        data={{
          nodes: schedule
-            .filter((si) => !si.deleted)
-            .sort((a, b) => a.flags - b.flags)
+            .filter((si: ScheduleItem) => !si.deleted)
+            .sort((a: ScheduleItem, b: ScheduleItem) => a.flags - b.flags)
        }}
        theme={schedule_theme}
        layout={{ custom: true }}
--- a/interface/src/app/main/SchedulerDialog.tsx
+++ b/interface/src/app/main/SchedulerDialog.tsx
@@ -144,7 +144,10 @@ const SchedulerDialog = ({
    </Typography>
  );

-  const handleClose = (_event, reason: 'backdropClick' | 'escapeKeyDown') => {
+  const handleClose = (
+    _event: React.SyntheticEvent,
+    reason: 'backdropClick' | 'escapeKeyDown'
+  ) => {
    if (reason !== 'backdropClick') {
      onClose();
    }
@@ -325,7 +328,7 @@ const SchedulerDialog = ({
          </>
        )}
        <ValidatedTextField
-          fieldErrors={fieldErrors}
+          fieldErrors={fieldErrors || {}}
          name="cmd"
          label={LL.COMMAND(0)}
          multiline
@@ -344,7 +347,7 @@ const SchedulerDialog = ({
          onChange={updateFormValue}
        />
        <ValidatedTextField
-          fieldErrors={fieldErrors}
+          fieldErrors={fieldErrors || {}}
          name="name"
          label={LL.NAME(0) + ' (' + LL.OPTIONAL() + ')'}
          value={editItem.name}
--- a/interface/src/app/main/SensorsAnalogDialog.tsx
+++ b/interface/src/app/main/SensorsAnalogDialog.tsx
@@ -57,7 +57,10 @@ const SensorsAnalogDialog = ({
    }
  }, [open, selectedItem]);

-  const handleClose = (_event, reason: 'backdropClick' | 'escapeKeyDown') => {
+  const handleClose = (
+    _event: React.SyntheticEvent,
+    reason: 'backdropClick' | 'escapeKeyDown'
+  ) => {
    if (reason !== 'backdropClick') {
      onClose();
    }
@@ -88,7 +91,7 @@ const SensorsAnalogDialog = ({
        <Grid container spacing={2}>
          <Grid>
            <ValidatedTextField
-              fieldErrors={fieldErrors}
+              fieldErrors={fieldErrors || {}}
              name="g"
              label="GPIO"
              sx={{ width: '11ch' }}
@@ -107,7 +110,7 @@ const SensorsAnalogDialog = ({
          )}
          <Grid>
            <ValidatedTextField
-              fieldErrors={fieldErrors}
+              fieldErrors={fieldErrors || {}}
              name="n"
              label={LL.NAME(0)}
              value={editItem.n}
--- a/interface/src/app/main/SensorsTemperatureDialog.tsx
+++ b/interface/src/app/main/SensorsTemperatureDialog.tsx
@@ -52,7 +52,10 @@ const SensorsTemperatureDialog = ({
    }
  }, [open, selectedItem]);

-  const handleClose = (_event, reason: 'backdropClick' | 'escapeKeyDown') => {
+  const handleClose = (
+    _event: React.SyntheticEvent,
+    reason: 'backdropClick' | 'escapeKeyDown'
+  ) => {
    if (reason !== 'backdropClick') {
      onClose();
    }
@@ -82,7 +85,7 @@ const SensorsTemperatureDialog = ({
        <Grid container spacing={2}>
          <Grid>
            <ValidatedTextField
-              fieldErrors={fieldErrors}
+              fieldErrors={fieldErrors || {}}
              name="n"
              label={LL.NAME(0)}
              value={editItem.n}
--- a/interface/src/app/main/validators.ts
+++ b/interface/src/app/main/validators.ts
@@ -13,7 +13,7 @@ import type {

 export const GPIO_VALIDATOR = {
  validator(
-    rule: InternalRuleItem,
+    _rule: InternalRuleItem,
    value: number,
    callback: (error?: string) => void
  ) {
@@ -36,7 +36,7 @@ export const GPIO_VALIDATOR = {

 export const GPIO_VALIDATORR = {
  validator(
-    rule: InternalRuleItem,
+    _rule: InternalRuleItem,
    value: number,
    callback: (error?: string) => void
  ) {
@@ -60,7 +60,7 @@ export const GPIO_VALIDATORR = {

 export const GPIO_VALIDATORC3 = {
  validator(
-    rule: InternalRuleItem,
+    _rule: InternalRuleItem,
    value: number,
    callback: (error?: string) => void
  ) {
@@ -74,7 +74,7 @@ export const GPIO_VALIDATORC3 = {

 export const GPIO_VALIDATORS2 = {
  validator(
-    rule: InternalRuleItem,
+    _rule: InternalRuleItem,
    value: number,
    callback: (error?: string) => void
  ) {
@@ -94,7 +94,7 @@ export const GPIO_VALIDATORS2 = {

 export const GPIO_VALIDATORS3 = {
  validator(
-    rule: InternalRuleItem,
+    _rule: InternalRuleItem,
    value: number,
    callback: (error?: string) => void
  ) {
@@ -279,7 +279,7 @@ export const createSettingsValidator = (settings: Settings) =>

 export const uniqueNameValidator = (schedule: ScheduleItem[], o_name?: string) => ({
  validator(
-    rule: InternalRuleItem,
+    _rule: InternalRuleItem,
    name: string,
    callback: (error?: string) => void
  ) {
@@ -324,7 +324,7 @@ export const uniqueCustomNameValidator = (
  o_name?: string
 ) => ({
  validator(
-    rule: InternalRuleItem,
+    _rule: InternalRuleItem,
    name: string,
    callback: (error?: string) => void
  ) {
@@ -353,7 +353,7 @@ export const entityItemValidation = (entity: EntityItem[], entityItem: EntityIte
    device_id: [
      {
        validator(
-          rule: InternalRuleItem,
+          _rule: InternalRuleItem,
          value: string,
          callback: (error?: string) => void
        ) {
@@ -367,7 +367,7 @@ export const entityItemValidation = (entity: EntityItem[], entityItem: EntityIte
    type_id: [
      {
        validator(
-          rule: InternalRuleItem,
+          _rule: InternalRuleItem,
          value: string,
          callback: (error?: string) => void
        ) {
@@ -389,7 +389,7 @@ export const uniqueTemperatureNameValidator = (
  sensors: TemperatureSensor[],
  o_name?: string
 ) => ({
-  validator(rule: InternalRuleItem, n: string, callback: (error?: string) => void) {
+  validator(_rule: InternalRuleItem, n: string, callback: (error?: string) => void) {
    if (
      (o_name === undefined || o_name.toLowerCase() !== n.toLowerCase()) &&
      n !== '' &&
@@ -419,7 +419,7 @@ export const temperatureSensorItemValidation = (

 export const isGPIOUniqueValidator = (sensors: AnalogSensor[]) => ({
  validator(
-    rule: InternalRuleItem,
+    _rule: InternalRuleItem,
    gpio: number,
    callback: (error?: string) => void
  ) {
@@ -435,7 +435,7 @@ export const uniqueAnalogNameValidator = (
  sensors: AnalogSensor[],
  o_name?: string
 ) => ({
-  validator(rule: InternalRuleItem, n: string, callback: (error?: string) => void) {
+  validator(_rule: InternalRuleItem, n: string, callback: (error?: string) => void) {
    if (
      (o_name === undefined || o_name.toLowerCase() !== n.toLowerCase()) &&
      n !== '' &&
@@ -482,7 +482,7 @@ export const deviceValueItemValidation = (dv: DeviceValue) =>
      { required: true, message: 'Value is required' },
      {
        validator(
-          rule: InternalRuleItem,
+          _rule: InternalRuleItem,
          value: unknown,
          callback: (error?: string) => void
        ) {