andry/EMS-ESP32
1
0
Fork 0
mirror of https://github.com/emsesp/EMS-ESP32.git synced 2025-12-06 15:59:52 +03:00
Code Issues Packages Projects Releases Wiki Activity

lint warnings

Browse Source
This commit is contained in:
proddy
2025-01-26 13:30:53 +01:00
parent 20b978c46c
commit 2620f56e0d
4 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/core/command.cpp
View File

@@ -220,7 +220,7 @@ const char * Command::return_code_string(const uint8_t return_code) {
default: default:
break; break;
} }
static char s[4]; static char s[4]; // static to avoid allocation on each call and loosing scope
return Helpers::smallitoa(s, return_code); return Helpers::smallitoa(s, return_code);
} }

4
src/core/emsdevice.cpp
View File

@@ -586,7 +586,7 @@ void EMSdevice::add_device_value(int8_t tag, // to b
if ((entityCustomization.product_id == product_id()) && (entityCustomization.device_id == device_id())) { if ((entityCustomization.product_id == product_id()) && (entityCustomization.device_id == device_id())) {
char entity[70]; char entity[70];
if (tag < DeviceValueTAG::TAG_HC1) { if (tag < DeviceValueTAG::TAG_HC1) {
strncpy(entity, short_name, sizeof(entity)); strncpy(entity, short_name, sizeof(entity)-1);
} else { } else {
snprintf(entity, sizeof(entity), "%s/%s", tag_to_mqtt(tag), short_name); snprintf(entity, sizeof(entity), "%s/%s", tag_to_mqtt(tag), short_name);
} }
@@ -1201,7 +1201,7 @@ void EMSdevice::setCustomizationEntity(const std::string & entity_id) {
for (auto & dv : devicevalues_) { for (auto & dv : devicevalues_) {
char entity_name[70]; char entity_name[70];
if (dv.tag < DeviceValueTAG::TAG_HC1) { if (dv.tag < DeviceValueTAG::TAG_HC1) {
strncpy(entity_name, dv.short_name, sizeof(entity_name)); strncpy(entity_name, dv.short_name, sizeof(entity_name)-1);
} else { } else {
snprintf(entity_name, sizeof(entity_name), "%s/%s", tag_to_mqtt(dv.tag), dv.short_name); snprintf(entity_name, sizeof(entity_name), "%s/%s", tag_to_mqtt(dv.tag), dv.short_name);
} }

2
src/core/emsdevice.h
View File

@@ -151,7 +151,7 @@ class EMSdevice {
} }
void has_update(char * value, const char * newvalue, size_t len) { void has_update(char * value, const char * newvalue, size_t len) {
if (strcmp(value, newvalue) != 0) { if (value && strcmp(value, newvalue) != 0) {
strlcpy(value, newvalue, len); strlcpy(value, newvalue, len);
has_update_ = true; has_update_ = true;
publish_value(value); publish_value(value);

10
src/devices/boiler.cpp
View File

@@ -1211,7 +1211,9 @@ void Boiler::process_UBAFactory(std::shared_ptr<const Telegram> telegram) {
return; return;
} }
toggle_fetch(telegram->type_id, false); // only read once toggle_fetch(telegram->type_id, false); // only read once
uint8_t min, max, nomPower; uint8_t min = 0;
uint8_t max = 0;
uint8_t nomPower = 0;
telegram->read_value(nomPower, 4); telegram->read_value(nomPower, 4);
telegram->read_value(min, 5); telegram->read_value(min, 5);
telegram->read_value(max, 6); telegram->read_value(max, 6);
@@ -1777,7 +1779,9 @@ void Boiler::process_UBAOutdoorTemp(std::shared_ptr<const Telegram> telegram) {
// UBASetPoint 0x1A // UBASetPoint 0x1A
void Boiler::process_UBASetPoints(std::shared_ptr<const Telegram> telegram) { void Boiler::process_UBASetPoints(std::shared_ptr<const Telegram> telegram) {
uint8_t setFlowTemp_, setBurnPow_, wwSetBurnPow_; uint8_t setFlowTemp_ = 0;
uint8_t setBurnPow_ = 0;
uint8_t wwSetBurnPow_ = 0;
telegram->read_value(setFlowTemp_, 0); telegram->read_value(setFlowTemp_, 0);
telegram->read_value(setBurnPow_, 1); telegram->read_value(setBurnPow_, 1);
telegram->read_value(wwSetBurnPow_, 2); telegram->read_value(wwSetBurnPow_, 2);
@@ -2936,7 +2940,7 @@ bool Boiler::set_HpInLogic(const char * value, const int8_t id) {
return true; return true;
} }
char option[] = {"xxxxxxxxxxxxxxx"}; char option[] = {"xxxxxxxxxxxxxxx"};
strncpy(option, value, strlen(value)); // copy without termination strncpy(option, value, strlen(option)); // copy without termination
// inputs 1,2,3 <inv>[<evu1><evu2><evu3><comp><aux><cool><heat><dhw><pv><prot><pres><mod>] // inputs 1,2,3 <inv>[<evu1><evu2><evu3><comp><aux><cool><heat><dhw><pv><prot><pres><mod>]
if (id < 4) { if (id < 4) {
uint8_t index[] = {0, 3, 6, 9, 12, 15, 18, 21, 24, 39, 36, 30}; uint8_t index[] = {0, 3, 6, 9, 12, 15, 18, 21, 24, 39, 36, 30};