From 3113a4be2bc9bf023d880a45bf40009588e68dd8 Mon Sep 17 00:00:00 2001 From: proddy Date: Mon, 24 Nov 2025 23:25:43 +0100 Subject: [PATCH] remove old todos --- lib/uuid-syslog/src/syslog.cpp | 1 - scripts/run_native.py | 1 - src/ESP32React/NetworkSettingsService.cpp | 1 - 3 files changed, 3 deletions(-) diff --git a/lib/uuid-syslog/src/syslog.cpp b/lib/uuid-syslog/src/syslog.cpp index e0309ba24..024fa6665 100644 --- a/lib/uuid-syslog/src/syslog.cpp +++ b/lib/uuid-syslog/src/syslog.cpp @@ -346,7 +346,6 @@ void SyslogService::loop() { } bool SyslogService::can_transmit() { - // TODO this should be checked also for Eth if (!host_.empty() && (uint32_t)ip_ == 0) { WiFi.hostByName(host_.c_str(), ip_); } diff --git a/scripts/run_native.py b/scripts/run_native.py index d79f835d0..229316993 100644 --- a/scripts/run_native.py +++ b/scripts/run_native.py @@ -36,7 +36,6 @@ def move_file(source, target, env): print("app version: " + app_version) print("platform: " + platform) - # TODO do we need to add a .exe extension for windows? - need to test variant = "native" # check if output directories exist and create if necessary diff --git a/src/ESP32React/NetworkSettingsService.cpp b/src/ESP32React/NetworkSettingsService.cpp index 07837a606..ffb6275c9 100644 --- a/src/ESP32React/NetworkSettingsService.cpp +++ b/src/ESP32React/NetworkSettingsService.cpp @@ -24,7 +24,6 @@ static bool formatBssid(const String & bssid, uint8_t (&mac)[6]) { } void NetworkSettingsService::begin() { - // TODO: may need to change this for Arduino Core 3.1 / IDF 5.x // We want the device to come up in opmode=0 (WIFI_OFF), when erasing the flash this is not the default. // If needed, we save opmode=0 before disabling persistence so the device boots with WiFi disabled in the future. if (WiFi.getMode() != WIFI_OFF) {