mirror of
https://github.com/emsesp/EMS-ESP32.git
synced 2025-12-06 15:59:52 +03:00
add TODO comments so reminding me what to do next
This commit is contained in:
@@ -638,6 +638,7 @@ void AnalogSensor::publish_values(const bool force) {
|
|||||||
|
|
||||||
// called from emsesp.cpp, similar to the emsdevice->get_value_info
|
// called from emsesp.cpp, similar to the emsdevice->get_value_info
|
||||||
// searches by name
|
// searches by name
|
||||||
|
// TODO see if this can replace the command_info
|
||||||
bool AnalogSensor::get_value_info(JsonObject output, const char * cmd, const int8_t id) const {
|
bool AnalogSensor::get_value_info(JsonObject output, const char * cmd, const int8_t id) const {
|
||||||
if (sensors_.empty()) {
|
if (sensors_.empty()) {
|
||||||
return true;
|
return true;
|
||||||
@@ -700,6 +701,7 @@ bool AnalogSensor::get_value_info(JsonObject output, const char * cmd, const int
|
|||||||
|
|
||||||
// creates JSON doc from values
|
// creates JSON doc from values
|
||||||
// returns true if there are no sensors
|
// returns true if there are no sensors
|
||||||
|
// TODO see if this can be merged with get_value_info so we can remove the commands (info, commands, etc...)
|
||||||
bool AnalogSensor::command_info(const char * value, const int8_t id, JsonObject output) const {
|
bool AnalogSensor::command_info(const char * value, const int8_t id, JsonObject output) const {
|
||||||
if (sensors_.empty()) {
|
if (sensors_.empty()) {
|
||||||
return true;
|
return true;
|
||||||
|
|||||||
Reference in New Issue
Block a user