andry/EMS-ESP32
1
0
Fork 0
mirror of https://github.com/emsesp/EMS-ESP32.git synced 2025-12-07 00:09:51 +03:00
Code Issues Packages Projects Releases Wiki Activity

update

Browse Source
This commit is contained in:
proddy
2021-07-20 13:00:01 +02:00
parent 93885d0dd5
commit 33adf518ae
1 changed files with 29 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
CONTRIBUTING.md
View File

@@ -32,8 +32,8 @@ This document describes rules that are in effect for this repository, meant for
6. Issues with feature requests should be discussed for viability/desirability. 6. Issues with feature requests should be discussed for viability/desirability.
7. Feature requests or changes that are meant to address a very specific/limited use case, especially if at the expense of increased code complexity, may be denied, or may be required to be redesigned, generalized, or simplified. 7. Feature requests or changes that are meant to address a very specific/limited use case, especially if at the expense of increased code complexity, may be denied, or may be required to be redesigned, generalized, or simplified.
8. Feature requests that are not accompanied by a PR: 8. Feature requests that are not accompanied by a PR:
* could be closed immediately (denied). - could be closed immediately (denied).
* could be closed after some predetermined period of time (left as candidate for somebody to pick up). - could be closed after some predetermined period of time (left as candidate for somebody to pick up).
9. In some cases, feedback may be requested from the issue reporter, either as additional info for clarification, additional testing, or other. If no feedback is provided, the issue may be closed by a contributor or after 40 days by the STALE bot. 9. In some cases, feedback may be requested from the issue reporter, either as additional info for clarification, additional testing, or other. If no feedback is provided, the issue may be closed by a contributor or after 40 days by the STALE bot.
## Pull requests ## Pull requests
@@ -42,24 +42,24 @@ A Pull Request (PR) is the process where code modifications are managed in GitHu
The process is straight-forward. The process is straight-forward.
- Read [How to get faster PR reviews](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#best-practices-for-faster-reviews) by Kubernetes (but skip step 0) - Read [How to get faster PR reviews](https://github.com/kubernetes/community/blob/master/contributors/guide/pull-requests.md#best-practices-for-faster-reviews) by Kubernetes (but skip step 0)
- Fork the EMS-ESP Repository [git repository](https://github.com/emsesp/EMS-ESP32). - Fork the EMS-ESP Repository [git repository](https://github.com/emsesp/EMS-ESP32).
- Write/Change the code in your Fork for a new feature, bug fix, new sensor, optimization, etc. - Write/Change the code in your Fork for a new feature, bug fix, new sensor, optimization, etc.
- Ensure tests work. - Ensure tests work.
- Create a Pull Request against the [**dev**](https://github.com/emsesp/EMS-ESP32/tree/dev) branch of EMS-ESP. - Create a Pull Request against the [**dev**](https://github.com/emsesp/EMS-ESP32/tree/dev) branch of EMS-ESP.
1. All pull requests must be done against the dev branch. 1. All pull requests must be done against the dev branch.
2. Make sure code is formatting per the `.clang-format` 2. Make sure code is formatting per the `.clang-format`.
3. Only relevant files should be touched (Also beware if your editor has auto-formatting feature enabled). 3. Make sure any new code is clearly commented explaining what the function/logic does.
4. Only one feature/fix should be added per PR. 4. Only relevant files should be touched (Also beware if your editor has auto-formatting feature enabled).
5. PRs that don't compile (fail in CI Tests) or cause coding errors will not be merged. Please fix the issue. Same goes for PRs that are raised against older commit in dev - you might need to rebase and resolve conflicts. 5. Only one feature/fix should be added per PR.
6. All pull requests should undergo peer review by at least one contributor other than the creator, excepts for the owner. 6. PRs that don't compile (fail in CI Tests) or cause coding errors will not be merged. Please fix the issue. Same goes for PRs that are raised against older commit in dev - you might need to rebase and resolve conflicts.
7. All pull requests should consider updates to the documentation. 7. All pull requests should undergo peer review by at least one contributor other than the creator, excepts for the owner.
8. Pull requests that address an outstanding issue, particularly an issue deemed to be severe, should be given priority. 8. All pull requests should consider updates to the documentation.
9. If a PR is accepted, then it should undergo review and updated based on the feedback provided, then merged. 9. Pull requests that address an outstanding issue, particularly an issue deemed to be severe, should be given priority.
10. By submitting a PR, it is needed to use the provided PR template and check all boxes, performing the required tasks and accepting the CLA. 10. If a PR is accepted, then it should undergo review and updated based on the feedback provided, then merged.
11. Pull requests that don't meet the above will be denied and closed. 11. By submitting a PR, it is needed to use the provided PR template and check all boxes, performing the required tasks and accepting the CLA.
12. Pull requests that don't meet the above will be denied and closed.
## Semantic Commit Messages ## Semantic Commit Messages
@@ -92,7 +92,7 @@ More Examples:
References: References:
- https://www.conventionalcommits.org/ - <https://www.conventionalcommits.org/>
-------------------------------------- --------------------------------------