andry/EMS-ESP32
1
0
Fork 0
mirror of https://github.com/emsesp/EMS-ESP32.git synced 2025-12-07 16:29:51 +03:00
Code Issues Packages Projects Releases Wiki Activity

use safer strcmp() instead of comparing pointers

Browse Source
This commit is contained in:
proddy
2023-03-05 14:32:20 +01:00
parent 3c10d750f0
commit 50d489d3c1
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/emsdevice.cpp
View File

@@ -1050,8 +1050,7 @@ void EMSdevice::generate_values_web_customization(JsonArray & output) {
void EMSdevice::set_climate_minmax(uint8_t tag, int16_t min, uint16_t max) { void EMSdevice::set_climate_minmax(uint8_t tag, int16_t min, uint16_t max) {
for (auto & dv : devicevalues_) { for (auto & dv : devicevalues_) {
// TODO check if pointer reference is safe. strcpy better? if (dv.tag == tag && (strcmp(dv.short_name, FL_(haclimate[0])) == 0)) {
if (dv.tag == tag && dv.short_name == FL_(haclimate[0])) {
if (dv.min != min || dv.max != max) { if (dv.min != min || dv.max != max) {
dv.min = min; dv.min = min;
dv.max = max; dv.max = max;