diff --git a/CHANGELOG_LATEST.md b/CHANGELOG_LATEST.md index b665af1e2..b128f1fab 100644 --- a/CHANGELOG_LATEST.md +++ b/CHANGELOG_LATEST.md @@ -38,6 +38,8 @@ - Added Shower Alert trigger time and cold shot time [#436](https://github.com/emsesp/EMS-ESP32/issues/436) - Improved Table layout in Web UI (searching, filtering, sorting, exporting to CSV) - API fetch individual attributes from an entity [#462](https://github.com/emsesp/EMS-ESP32/issues/462) +- Option to disable mDNS +- Option for rendering booleans on dashboard [#456](https://github.com/emsesp/EMS-ESP32/issues/456) ### Fixed diff --git a/interface/src/framework/network/NetworkSettingsForm.tsx b/interface/src/framework/network/NetworkSettingsForm.tsx index b15eb66f5..c1221713d 100644 --- a/interface/src/framework/network/NetworkSettingsForm.tsx +++ b/interface/src/framework/network/NetworkSettingsForm.tsx @@ -56,7 +56,8 @@ const WiFiSettingsForm: FC = () => { enableIPv6: false, bandwidth20: false, tx_power: 20, - nosleep: false + nosleep: false, + enableMDNS: true }); } setInitialized(true); @@ -153,6 +154,11 @@ const WiFiSettingsForm: FC = () => { label="Use Lower WiFi Bandwidth" /> + } + label="Enable mDNS Service" + /> + General diff --git a/interface/src/project/SettingsApplication.tsx b/interface/src/project/SettingsApplication.tsx index 353f1faf0..945dfa137 100644 --- a/interface/src/project/SettingsApplication.tsx +++ b/interface/src/project/SettingsApplication.tsx @@ -402,10 +402,27 @@ const SettingsApplication: FC = () => { Formatting Options - + + + on/off + ON/OFF + true/false + 1/0 + + + { 1/0 - + read([&](NetworkSettings & networkSettings) { + if (networkSettings.enableMDNS) { + if (!MDNS.begin(EMSESP::system_.hostname().c_str())) { + EMSESP::logger().warning(F("Failed to start mDNS responder service")); + return; + } - std::string address_s = EMSESP::system_.hostname() + ".local"; + std::string address_s = EMSESP::system_.hostname() + ".local"; - MDNS.addService("http", "tcp", 80); // add our web server and rest API - MDNS.addService("telnet", "tcp", 23); // add our telnet console + MDNS.addService("http", "tcp", 80); // add our web server and rest API + MDNS.addService("telnet", "tcp", 23); // add our telnet console - MDNS.addServiceTxt("http", "tcp", "version", EMSESP_APP_VERSION); - MDNS.addServiceTxt("http", "tcp", "address", address_s.c_str()); + MDNS.addServiceTxt("http", "tcp", "version", EMSESP_APP_VERSION); + MDNS.addServiceTxt("http", "tcp", "address", address_s.c_str()); + + EMSESP::logger().info(F("mDNS responder service started")); + } + }); +#else + EMSESP::esp8266React.getNetworkSettingsService()->read([&](NetworkSettings & networkSettings) { + if (networkSettings.enableMDNS) { + EMSESP::logger().info(F("mDNS responder service started")); + } + }); #endif - - EMSESP::logger().info(F("mDNS responder service started")); } } // namespace emsesp \ No newline at end of file