From 7e9f27a613171ee3327c7f7049751044349662d2 Mon Sep 17 00:00:00 2001 From: proddy Date: Fri, 26 Dec 2025 09:32:46 +0100 Subject: [PATCH] tidy up comments --- src/devices/connect.cpp | 9 +++--- src/devices/solar.cpp | 28 ++++++++---------- src/devices/ventilation.h | 62 --------------------------------------- 3 files changed, 17 insertions(+), 82 deletions(-) diff --git a/src/devices/connect.cpp b/src/devices/connect.cpp index 29bc56c6a..78c615187 100644 --- a/src/devices/connect.cpp +++ b/src/devices/connect.cpp @@ -81,11 +81,10 @@ void Connect::process_RCTime(std::shared_ptr telegram) { has_update(dateTime_, time, sizeof(dateTime_)); } -/* other values from 0x50 RF base -(0x087F), data: 00 00 -(0x0880), data: 01 04 -(0x0889), data: 00 80 80 01 -*/ +// other values from 0x50 RF base +// (0x087F), data: 00 00 +// (0x0880), data: 01 04 +// (0x0889), data: 00 80 80 01 void Connect::register_device_values_room(std::shared_ptr room) { auto tag = DeviceValueTAG::TAG_SRC1 + room->room(); register_device_value(tag, &room->temp_, DeviceValueType::INT16, DeviceValueNumOp::DV_NUMOP_DIV10, FL_(roomTemp), DeviceValueUOM::DEGREES); diff --git a/src/devices/solar.cpp b/src/devices/solar.cpp index 95f8a2861..28ba574c4 100644 --- a/src/devices/solar.cpp +++ b/src/devices/solar.cpp @@ -563,21 +563,19 @@ void Solar::process_SM100Differential(std::shared_ptr telegram) has_update(telegram, diffControl_, 0); // is *10 } -/* process_SM100ParamCfg - type 0xF9 EMS 1.0 - * This telegram is used to inquire the min, default, max, and current values of a value that is usually read and written with another telegram ID - * The CS200 uses this method extensively to find out which values may be set in the SM100 - * e.g. B0 10 F9 00 FF 02 5A 03 17 00 00 00 14 00 00 00 3C 00 00 00 5A 00 00 00 59 29 - requested with 90 B0 F9 00 11 FF 02 5A 03 AF - * byte 0 = 0xFF - * byte 1-2 = telegram ID used to write this value - * byte 3 = offset in telegram used to write this value - * byte 4 = unknown - * bytes 5..8 = minimum value - * bytes 9..12 = default value - * bytes 13..16 = maximum value - * bytes 17..20 = current value - * - * e.g. B0 0B F9 00 00 02 5A 00 00 6E - */ +// process_SM100ParamCfg - type 0xF9 EMS 1.0 +// This telegram is used to inquire the min, default, max, and current values of a value that is usually read and written with another telegram ID +// The CS200 uses this method extensively to find out which values may be set in the SM100 +// e.g. B0 10 F9 00 FF 02 5A 03 17 00 00 00 14 00 00 00 3C 00 00 00 5A 00 00 00 59 29 - requested with 90 B0 F9 00 11 FF 02 5A 03 AF +// byte 0 = 0xFF +// byte 1-2 = telegram ID used to write this value +// byte 3 = offset in telegram used to write this value +// byte 4 = unknown +// bytes 5..8 = minimum value +// bytes 9..12 = default value +// bytes 13..16 = maximum value +// bytes 17..20 = current value +// e.g. B0 0B F9 00 00 02 5A 00 00 6E void Solar::process_SM100ParamCfg(std::shared_ptr telegram) { uint16_t t_id = EMS_VALUE_UINT16_NOTSET; uint8_t of = EMS_VALUE_UINT8_NOTSET; diff --git a/src/devices/ventilation.h b/src/devices/ventilation.h index 9421f85c9..21a3ee028 100644 --- a/src/devices/ventilation.h +++ b/src/devices/ventilation.h @@ -51,68 +51,6 @@ class Ventilation : public EMSdevice { bool set_ventMode(const char * value, const int8_t id); bool set_bypass(const char * value, const int8_t id); bool set_filter(const char * value, const int8_t id); - - - /* Sensors: - outdoor air temp (außenluft) - supply air temp (zuluft) - extract air temp (abluft) - away air temp (fortluft) - supply blower (zuluftgebläse) - supply blower mod (zuluftebläse drehzahl) - away blower (abluftgebläse) - away blower mod (abluftgebläse drehzahl) - Anschlussvariante - el. vorheizer - ext. el. vorheizreg. - nachheiz zulufttemp - mischer öffnen - mischer schließen - mischerposition - zuluft temp soll - zuluft temp ist - leistung nachheizreg. - erdwärmetauscher klappe - solekreispumpe - abluftfeuchte - abluftqualität - raumluftfechte - raumluftqualität - luftfeuchte fernbed. 1..4 - */ - /* Parameters: - Gerätetyp, - Nennvolumentstrom, - Filterlaufzeit 1-6-12 m - Filterwechsel confirm CMD - Lüftungsfrostschutz: _el._preheat_, Disballance | Interval - Ext. Frostschutz: on/_off_ - Bypass _on_, off - min. outdoortemp 12 15 19 °C - max. outdoortemp 21-24-30 C - Enthalpie Wärmetauscher instaliert nein-ja - Feuchteschutz AUs/ 1-24 h - Lüfterstufe 1-4, Drehzahlanpassung - ext. Luftfeuchtefühler inst.? _nein_, ja - Abluftfeuchtefühler inst.? _nein_, ja - Luftfeuchte Fernbed. _nein_, ja - Luftfeuchte: trocken, _normal_, feucht - Abluftqualitätsfühler inst. _ja_, nein - ext. Luftqualfühl? _nein_, ja - Lufqualität: ausreichend, _normal_, hoch - el. Nachheizregister inst. _nein_, ja - Nachheiz-Zuluft temp: 10-22-30 °C - Erdwärmetauscher inst? _nein_, Luft, Sole - Taster Funktion: nein, einschlafen, intensiv, bypass, party, kamin - ext. Störung aktivieren: _nein_, ja, invertiert - Dauer einschlafen: 15-60-120 min - Dauer Intensiv: 5-15-60 min - Dauer Bypass Abluft: 1-8-12 h - Dauer Bypass: 1-8-12 h - Dauer PArty 1-8-12 h - Dauer Kamin: 5-10-15 min - Volumenstromabgleich 90-100-110 % - */ }; } // namespace emsesp