andry/EMS-ESP32
1
0
Fork 0
mirror of https://github.com/emsesp/EMS-ESP32.git synced 2025-12-06 07:49:52 +03:00
Code Issues Packages Projects Releases Wiki Activity

fix nullptr linter error

Browse Source
This commit is contained in:
mheyse
2024-07-04 09:00:12 +02:00
parent a0ca1ce87c
commit 8c810f2276
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/modbus.cpp
View File

@@ -65,8 +65,10 @@ bool Modbus::check_parameter_order() {
for (const auto & mi : modbus_register_mappings) { for (const auto & mi : modbus_register_mappings) {
if (isFirst) { if (isFirst) {
isFirst = false; isFirst = false;
} else if (prev == nullptr || !prev->isLessThan(mi)) { } else if (prev == nullptr) {
// TODO fix nullptr dereference when printing LOG_ERROR("Error checking modbus parameters %s.", mi.short_name);
return false;
} else if(!prev->isLessThan(mi)) {
LOG_ERROR("Error in modbus parameters: %s must be listed before %s.", mi.short_name, prev->short_name); LOG_ERROR("Error in modbus parameters: %s must be listed before %s.", mi.short_name, prev->short_name);
return false; return false;
} }