andry/EMS-ESP32
1
0
Fork 0
mirror of https://github.com/emsesp/EMS-ESP32.git synced 2025-12-07 16:29:51 +03:00
Code Issues Packages Projects Releases Wiki Activity

add TODO on possible memory out-of-bounds error

Browse Source
This commit is contained in:
Proddy
2023-09-23 18:41:54 +02:00
parent 41228e894a
commit 917e268ac9
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/devices/thermostat.cpp
View File

@@ -843,6 +843,8 @@ void Thermostat::process_RC35wwTimer(std::shared_ptr<const Telegram> telegram) {
if (telegram->type_id != 0x38) { if (telegram->type_id != 0x38) {
return; return;
} }
// TODO: should this be >= 87 to avoid out of bounds?
if (telegram->message_length + telegram->offset >= 92 && telegram->offset <= 87) { if (telegram->message_length + telegram->offset >= 92 && telegram->offset <= 87) {
char data[sizeof(wwVacation_)]; char data[sizeof(wwVacation_)];
snprintf(data, snprintf(data,