From 944d86b64475eaff711e01c65cde6cca2ae3c768 Mon Sep 17 00:00:00 2001
From: proddy <paul@derbyshire.nl>
Date: Wed, 14 Feb 2024 15:07:35 +0100
Subject: [PATCH] removed unused _retained's

---
 lib/framework/MqttSettingsService.cpp | 4 ----
 lib/framework/MqttSettingsService.h   | 8 --------
 2 files changed, 12 deletions(-)

diff --git a/lib/framework/MqttSettingsService.cpp b/lib/framework/MqttSettingsService.cpp
index 9f7b88c8e..57d7f5313 100644
--- a/lib/framework/MqttSettingsService.cpp
+++ b/lib/framework/MqttSettingsService.cpp
@@ -4,10 +4,6 @@
 MqttSettingsService::MqttSettingsService(AsyncWebServer * server, FS * fs, SecurityManager * securityManager)
     : _httpEndpoint(MqttSettings::read, MqttSettings::update, this, server, MQTT_SETTINGS_SERVICE_PATH, securityManager)
     , _fsPersistence(MqttSettings::read, MqttSettings::update, this, fs, MQTT_SETTINGS_FILE)
-    , _retainedHost(nullptr)
-    , _retainedClientId(nullptr)
-    , _retainedUsername(nullptr)
-    , _retainedPassword(nullptr)
     , _reconfigureMqtt(false)
     , _disconnectedAt(0)
     , _disconnectReason(espMqttClientTypes::DisconnectReason::TCP_DISCONNECTED)
diff --git a/lib/framework/MqttSettingsService.h b/lib/framework/MqttSettingsService.h
index d4ddf9f86..9fe5ef71c 100644
--- a/lib/framework/MqttSettingsService.h
+++ b/lib/framework/MqttSettingsService.h
@@ -109,14 +109,6 @@ class MqttSettingsService : public StatefulService<MqttSettings> {
     HttpEndpoint<MqttSettings>  _httpEndpoint;
     FSPersistence<MqttSettings> _fsPersistence;
 
-    // Pointers to hold retained copies of the mqtt client connection strings.
-    // This is required as espMqttClient holds references to the supplied connection strings.
-    char * _retainedHost;
-    char * _retainedClientId;
-    char * _retainedUsername;
-    char * _retainedPassword;
-    char * _retainedRootCA;
-
     // variable to help manage connection
     bool          _reconfigureMqtt;
     unsigned long _disconnectedAt;