andry/EMS-ESP32
1
0
Fork 0
mirror of https://github.com/emsesp/EMS-ESP32.git synced 2025-12-07 00:09:51 +03:00
Code Issues Packages Projects Releases Wiki Activity

sensor fix buffer overflow

Browse Source
This commit is contained in:
MichaelDvP
2020-08-17 17:06:02 +02:00
parent 36931ef303
commit af6ce2c1ad
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/sensors.cpp
View File

@@ -255,7 +255,7 @@ void Sensors::publish_values() {
if (mqtt_format_ == MQTT_format::SINGLE) { if (mqtt_format_ == MQTT_format::SINGLE) {
StaticJsonDocument<100> doc; StaticJsonDocument<100> doc;
for (const auto & device : devices_) { for (const auto & device : devices_) {
char s[5]; char s[7]; // sensorrange -55.00 to 125.00
doc["temp"] = Helpers::render_value(s, device.temperature_c, 2); doc["temp"] = Helpers::render_value(s, device.temperature_c, 2);
char topic[60]; // sensors{1-n} char topic[60]; // sensors{1-n}
strlcpy(topic, "sensor_", 50); // create topic, e.g. home/ems-esp/sensor_28-EA41-9497-0E03-5F strlcpy(topic, "sensor_", 50); // create topic, e.g. home/ems-esp/sensor_28-EA41-9497-0E03-5F
@@ -281,12 +281,12 @@ void Sensors::publish_values() {
uint8_t i = 1; uint8_t i = 1;
for (const auto & device : devices_) { for (const auto & device : devices_) {
if (mqtt_format_ == MQTT_format::CUSTOM) { if (mqtt_format_ == MQTT_format::CUSTOM) {
char s[5]; char s[7];
doc[device.to_string()] = Helpers::render_value(s, device.temperature_c, 2); doc[device.to_string()] = Helpers::render_value(s, device.temperature_c, 2);
} else { } else {
char sensorID[10]; // sensor{1-n} char sensorID[10]; // sensor{1-n}
strlcpy(sensorID, "sensor", 10); strlcpy(sensorID, "sensor", 10);
char s[5]; char s[7];
strlcat(sensorID, Helpers::itoa(s, i++), 10); strlcat(sensorID, Helpers::itoa(s, i++), 10);
JsonObject dataSensor = doc.createNestedObject(sensorID); JsonObject dataSensor = doc.createNestedObject(sensorID);
dataSensor["id"] = device.to_string(); dataSensor["id"] = device.to_string();