From b2247f5f58badc822c1907ce71c6c5d1ac6b6010 Mon Sep 17 00:00:00 2001 From: proddy Date: Thu, 14 May 2026 12:10:42 +0200 Subject: [PATCH] tidy up --- src/web/WebStatusService.cpp | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/web/WebStatusService.cpp b/src/web/WebStatusService.cpp index 69dc2ca25..777580f19 100644 --- a/src/web/WebStatusService.cpp +++ b/src/web/WebStatusService.cpp @@ -295,19 +295,19 @@ uint8_t WebStatusService::upgradeImportantMessages(std::string & version) { FirmwareVersion current_version(current_version_s); // get current version - if ((current_version.major() <= 3 && current_version.minor() <= 8) && (latest_version.major() == 3 && latest_version.minor() == 9)) { - return 1; // if moving from below 3.8.x to 3.9.x return 1 + if (!(latest_version > current_version)) { + return 0; // no upgrade (same version or downgrade) } - if (latest_version > current_version && current_version.major() < latest_version.major()) { - return 2; // if it's a major version upgrade return 2 + if (current_version < FirmwareVersion("3.9.0") && latest_version.major() == 3 && latest_version.minor() == 9) { + return 1; // upgrading to 3.9.x from anything older - new partition layout warning } - if (latest_version > current_version && current_version.minor() < latest_version.minor()) { - return 0; // if it's just a minor version upgrade return 0 + if (current_version.major() < latest_version.major()) { + return 2; // major version upgrade } - return 0; // if it's not a valid version upgrade return 0 + return 0; // minor or patch upgrade, no special message } // action = getVersions