From cf89a064375308d6b7917b72e531bd9903960269 Mon Sep 17 00:00:00 2001 From: MichaelDvP Date: Wed, 15 Nov 2023 11:48:18 +0100 Subject: [PATCH] do not remove fetches --- CHANGELOG_LATEST.md | 1 + src/emsdevice.cpp | 5 +++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/CHANGELOG_LATEST.md b/CHANGELOG_LATEST.md index e5a6d0ef6..91c427b17 100644 --- a/CHANGELOG_LATEST.md +++ b/CHANGELOG_LATEST.md @@ -19,6 +19,7 @@ Writeable Text entities have moved from type `sensor` to `text` in Home Assistan - heatpump high res energy counters [#1348, #1349. #1350](https://github.com/emsesp/EMS-ESP32/issues/1348) - optional bssid in network settings - extension module EM100 [#1315](https://github.com/emsesp/EMS-ESP32/discussions/1315) +- digital_out with new options for polarity and startup state - Added 'system allvalues' command that dumps all the EMS device values, plus sensors and any custom entities ## Fixed diff --git a/src/emsdevice.cpp b/src/emsdevice.cpp index 824215ed7..127469928 100644 --- a/src/emsdevice.cpp +++ b/src/emsdevice.cpp @@ -333,7 +333,7 @@ bool EMSdevice::is_fetch(uint16_t telegram_id) const { return false; } -// get status of automatic fetch for a telegramID +// get receive status of telegramID bool EMSdevice::is_received(uint16_t telegram_id) const { for (const auto & tf : telegram_functions_) { if (tf.telegram_type_id_ == telegram_id) { @@ -1821,7 +1821,8 @@ bool EMSdevice::handle_telegram(std::shared_ptr telegram) { #if defined(EMSESP_DEBUG) EMSESP::logger().debug("This telegram (%s) is not recognized by the EMS bus", tf.telegram_type_name_); #endif - tf.fetch_ = false; + // removing fetch causes issue: https://github.com/emsesp/EMS-ESP32/issues/1420 + // tf.fetch_ = false; return false; } if (telegram->message_length > 0) {