andry/EMS-ESP32
1
0
Fork 0
mirror of https://github.com/emsesp/EMS-ESP32.git synced 2026-06-15 12:26:33 +03:00
Code Issues Packages Projects Releases Wiki Activity

optimize enum to avoid per-call adding enums to heap

Browse Source
This commit is contained in:
proddy
2026-05-19 17:45:48 +02:00
parent 5292f7ed17
commit d670bc2b07
1 changed files with 12 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
src/core/emsdevice.h
View File

@@ -26,6 +26,7 @@
#include "emsdevicevalue.h" #include "emsdevicevalue.h"
#include <esp32-psram.h> #include <esp32-psram.h>
#include <initializer_list>
#include <map> #include <map>
namespace emsesp { namespace emsesp {
@@ -223,16 +224,23 @@ class EMSdevice {
} }
} }
void has_enumupdate(const std::shared_ptr<const Telegram> & telegram, uint8_t & value, const uint8_t index, const std::vector<uint8_t> & maskIn) { // maskIn is taken as a std::initializer_list so brace-list call sites
uint8_t val = value < maskIn.size() ? maskIn[value] : EMS_VALUE_UINT8_NOTSET; // like has_enumupdate(t, v, idx, {0,5,1,2,4}) avoid the per-call
// heap allocation of a temporary std::vector<uint8_t>. The backing
// array of an initializer_list of integral constants is placed in
// static storage or on the stack — never on the heap.
void has_enumupdate(const std::shared_ptr<const Telegram> & telegram, uint8_t & value, const uint8_t index, std::initializer_list<uint8_t> maskIn) {
uint8_t val = value < maskIn.size() ? *(maskIn.begin() + value) : EMS_VALUE_UINT8_NOTSET;
if (telegram->read_value(val, index)) { if (telegram->read_value(val, index)) {
for (uint8_t i = 0; i < maskIn.size(); i++) { uint8_t i = 0;
if (val == maskIn[i]) { for (auto m : maskIn) {
if (val == m) {
value = i; value = i;
has_update_ = true; has_update_ = true;
publish_value((void *)&value); publish_value((void *)&value);
return; return;
} }
++i;
} }
} }
} }