Remove OTA feature #1738

interface/src/framework/Settings.tsx

@@ -3,7 +3,6 @@ import { toast } from 'react-toastify';
 
 import AccessTimeIcon from '@mui/icons-material/AccessTime';
 import CancelIcon from '@mui/icons-material/Cancel';
-import CastIcon from '@mui/icons-material/Cast';
 import DeviceHubIcon from '@mui/icons-material/DeviceHub';
 import ImportExportIcon from '@mui/icons-material/ImportExport';
 import LockIcon from '@mui/icons-material/Lock';
@@ -212,13 +211,7 @@ const Settings: FC = () => {
           text={LL.CONFIGURE('MQTT')}
           to="mqtt"
         />
-        <ListMenuItem
-          icon={CastIcon}
-          bgcolor="#efc34b"
-          label="OTA"
-          text={LL.CONFIGURE('OTA')}
-          to="ota"
-        />
+
         <ListMenuItem
           icon={LockIcon}
           label={LL.SECURITY(0)}

interface/src/framework/ota/OTASettings.tsx

@@ -1,141 +0,0 @@
-import { useState } from 'react';
-import type { FC } from 'react';
-
-import CancelIcon from '@mui/icons-material/Cancel';
-import WarningIcon from '@mui/icons-material/Warning';
-import { Button, Checkbox } from '@mui/material';
-
-import * as SystemApi from 'api/system';
-
-import type { ValidateFieldsError } from 'async-validator';
-import {
-  BlockFormControlLabel,
-  BlockNavigation,
-  ButtonRow,
-  FormLoader,
-  SectionContent,
-  ValidatedPasswordField,
-  ValidatedTextField,
-  useLayoutTitle
-} from 'components';
-import { useI18nContext } from 'i18n/i18n-react';
-import type { OTASettingsType } from 'types';
-import { numberValue, updateValueDirty, useRest } from 'utils';
-import { validate } from 'validators';
-import { OTA_SETTINGS_VALIDATOR } from 'validators/system';
-
-const OTASettings: FC = () => {
-  const {
-    loadData,
-    saveData,
-    saving,
-    updateDataValue,
-    data,
-    origData,
-    dirtyFlags,
-    setDirtyFlags,
-    blocker,
-    errorMessage
-  } = useRest<OTASettingsType>({
-    read: SystemApi.readOTASettings,
-    update: SystemApi.updateOTASettings
-  });
-
-  const { LL } = useI18nContext();
-
-  const updateFormValue = updateValueDirty(
-    origData,
-    dirtyFlags,
-    setDirtyFlags,
-    updateDataValue
-  );
-
-  const [fieldErrors, setFieldErrors] = useState<ValidateFieldsError>();
-
-  const content = () => {
-    if (!data) {
-      return <FormLoader onRetry={loadData} errorMessage={errorMessage} />;
-    }
-
-    const validateAndSubmit = async () => {
-      try {
-        setFieldErrors(undefined);
-        await validate(OTA_SETTINGS_VALIDATOR, data);
-        await saveData();
-      } catch (error) {
-        setFieldErrors(error as ValidateFieldsError);
-      }
-    };
-
-    useLayoutTitle('OTA');
-
-    return (
-      <>
-        <BlockFormControlLabel
-          control={
-            <Checkbox
-              name="enabled"
-              checked={data.enabled}
-              onChange={updateFormValue}
-            />
-          }
-          label={LL.ENABLE_OTA()}
-        />
-        <ValidatedTextField
-          fieldErrors={fieldErrors}
-          name="port"
-          label="Port"
-          fullWidth
-          variant="outlined"
-          value={numberValue(data.port)}
-          type="number"
-          onChange={updateFormValue}
-          margin="normal"
-        />
-        <ValidatedPasswordField
-          fieldErrors={fieldErrors}
-          name="password"
-          label={LL.PASSWORD()}
-          fullWidth
-          variant="outlined"
-          value={data.password}
-          onChange={updateFormValue}
-          margin="normal"
-        />
-        {dirtyFlags && dirtyFlags.length !== 0 && (
-          <ButtonRow>
-            <Button
-              startIcon={<CancelIcon />}
-              disabled={saving}
-              variant="outlined"
-              color="primary"
-              type="submit"
-              onClick={loadData}
-            >
-              {LL.CANCEL()}
-            </Button>
-            <Button
-              startIcon={<WarningIcon color="warning" />}
-              disabled={saving}
-              variant="contained"
-              color="info"
-              type="submit"
-              onClick={validateAndSubmit}
-            >
-              {LL.APPLY_CHANGES(dirtyFlags.length)}
-            </Button>
-          </ButtonRow>
-        )}
-      </>
-    );
-  };
-
-  return (
-    <SectionContent>
-      {blocker ? <BlockNavigation blocker={blocker} /> : null}
-      {content()}
-    </SectionContent>
-  );
-};
-
-export default OTASettings;

interface/src/framework/system/SystemStatus.tsx

@@ -4,7 +4,6 @@ import { toast } from 'react-toastify';
 import AccessTimeIcon from '@mui/icons-material/AccessTime';
 import BuildIcon from '@mui/icons-material/Build';
 import CancelIcon from '@mui/icons-material/Cancel';
-import CastIcon from '@mui/icons-material/Cast';
 import DeviceHubIcon from '@mui/icons-material/DeviceHub';
 import DirectionsBusIcon from '@mui/icons-material/DirectionsBus';
 import MemoryIcon from '@mui/icons-material/Memory';
@@ -277,20 +276,10 @@ const SystemStatus: FC = () => {
           />
           <Divider variant="inset" component="li" />
 
-          <ListMenuItem
-            disabled={!me.admin}
-            icon={CastIcon}
-            bgcolor={activeHighlight(data.ota_status)}
-            label={LL.STATUS_OF('OTA')}
-            text={data.ota_status ? LL.ACTIVE() : LL.INACTIVE(0)}
-            to="/settings/ota"
-          />
-          <Divider variant="inset" component="li" />
-
           <ListMenuItem
             disabled={!me.admin}
             icon={SettingsInputAntennaIcon}
-            bgcolor={activeHighlight(data.ota_status)}
+            bgcolor={activeHighlight(data.ap_status)}
             label={LL.ACCESS_POINT(0)}
             text={data.ap_status ? LL.ACTIVE() : LL.INACTIVE(0)}
             to="/settings/ap/status"