add is_system to analog sensor so internal sensors cannot be removed

interface/src/app/main/SensorsAnalogDialog.tsx

@@ -447,6 +447,7 @@ const SensorsAnalogDialog = ({
           <Box flexGrow={1} sx={{ '& button': { mt: 0 } }}>
             <Button
               startIcon={<RemoveIcon />}
+              disabled={editItem.s}
               variant="outlined"
               color="warning"
               onClick={remove}

interface/src/app/main/types.ts

@@ -95,6 +95,7 @@ export interface AnalogSensor {
   f: number;
   t: number;
   d: boolean; // deleted flag
+  s: boolean; // system customization flag
   o_n?: string;
 }
 

src/core/analogsensor.cpp

@@ -53,17 +53,22 @@ void AnalogSensor::start(const bool factory_settings) {
     if (factory_settings && analogReadMilliVolts(39) > 700) { // core voltage > 2.6V
         EMSESP::webCustomizationService.update([&](WebCustomization & settings) {
             auto newSensor = AnalogCustomization();
+
             newSensor.gpio      = 39;
             newSensor.name      = "core_voltage";
             newSensor.offset    = 0;
             newSensor.factor    = 0.00377136; // Divider 24k - 8,66k
             newSensor.uom       = DeviceValueUOM::VOLTS;
             newSensor.type      = AnalogType::ADC;
+            newSensor.is_system = true;
             settings.analogCustomizations.push_back(newSensor);
+
             newSensor.gpio      = 36;
             newSensor.name      = "supply_voltage";
             newSensor.factor    = 0.017; // Divider 24k - 1,5k
+            newSensor.is_system = true;
             settings.analogCustomizations.push_back(newSensor);
+
             return StateUpdateResult::CHANGED; // persist the change
         });
     }
@@ -469,7 +474,7 @@ void AnalogSensor::loop() {
 
 // update analog information name and offset
 // a type value of -1 is used to delete the sensor
-bool AnalogSensor::update(uint8_t gpio, std::string & name, double offset, double factor, uint8_t uom, int8_t type, bool deleted) {
+bool AnalogSensor::update(uint8_t gpio, std::string & name, double offset, double factor, uint8_t uom, int8_t type, bool deleted, bool is_system) {
     // first see if we can find the sensor in our customization list
     bool found_sensor = false;
     EMSESP::webCustomizationService.update([&](WebCustomization & settings) {
@@ -501,6 +506,7 @@ bool AnalogSensor::update(uint8_t gpio, std::string & name, double offset, doubl
                     AnalogCustomization.factor    = factor;
                     AnalogCustomization.uom       = uom;
                     AnalogCustomization.type      = type;
+                    AnalogCustomization.is_system = is_system;
                     LOG_DEBUG("Customizing existing analog GPIO %02d", gpio);
                 }
                 return StateUpdateResult::CHANGED; // persist the change
@@ -524,6 +530,7 @@ bool AnalogSensor::update(uint8_t gpio, std::string & name, double offset, doubl
             newSensor.factor    = factor;
             newSensor.uom       = uom;
             newSensor.type      = type;
+            newSensor.is_system = false;
             settings.analogCustomizations.push_back(newSensor);
             LOG_DEBUG("Adding new customization for analog sensor GPIO %02d", gpio);
             return StateUpdateResult::CHANGED; // persist the change
@@ -837,6 +844,7 @@ void AnalogSensor::get_value_json(JsonObject output, const Sensor & sensor) {
     output["writeable"] = sensor.type() == AnalogType::COUNTER || sensor.type() == AnalogType::RGB || sensor.type() == AnalogType::PULSE
                           || (sensor.type() >= AnalogType::DIGITAL_OUT && sensor.type() <= AnalogType::PWM_2);
     output["visible"]   = true;
+    output["is_system"] = sensor.is_system();
     if (sensor.type() == AnalogType::COUNTER) {
         output["min"]         = 0;
         output["max"]         = 4000000;

src/core/analogsensor.h

@@ -61,6 +61,10 @@ class AnalogSensor {
             value_ = value;
         }
 
+        bool is_system() const {
+            return is_system_;
+        }
+
         double factor() const {
             return factor_;
         }
@@ -107,6 +111,7 @@ class AnalogSensor {
         uint8_t     uom_;
         double      value_;     // double because of the factor is a double
         int8_t      type_;      // one of the AnalogType enum
+        bool        is_system_; // if true, the sensor is a system sensor
     };
 
     AnalogSensor()  = default;
@@ -167,7 +172,7 @@ class AnalogSensor {
         return sensors_.size();
     }
 
-    bool update(uint8_t gpio, std::string & name, double offset, double factor, uint8_t uom, int8_t type, bool deleted = false);
+    bool update(uint8_t gpio, std::string & name, double offset, double factor, uint8_t uom, int8_t type, bool deleted = false, bool is_system = false);
     bool get_value_info(JsonObject output, const char * cmd, const int8_t id = -1);
     void store_counters();
 

src/web/WebCustomizationService.cpp

@@ -70,6 +70,7 @@ void WebCustomization::read(WebCustomization & customizations, JsonObject root)
         sensorJson["factor"]    = sensor.factor;    // f
         sensorJson["uom"]       = sensor.uom;       // u
         sensorJson["type"]      = sensor.type;      // t
+        sensorJson["is_system"] = sensor.is_system; // s
     }
 
     // Masked entities customization and custom device name (optional)
@@ -122,6 +123,7 @@ StateUpdateResult WebCustomization::update(JsonObject root, WebCustomization & c
             analog.factor    = analogJson["factor"];
             analog.uom       = analogJson["uom"];
             analog.type      = analogJson["type"];
+            analog.is_system = analogJson["is_system"];
             if (_start && analog.type == EMSESP::analogsensor_.AnalogType::DIGITAL_OUT && analog.uom > DeviceValue::DeviceValueUOM::NONE) {
                 analog.offset = analog.uom - 1;
             }

src/web/WebCustomizationService.h

@@ -47,6 +47,7 @@ class AnalogCustomization {
     double      factor;
     uint8_t     uom;               // 0 is none
     int8_t      type;              // -1 is for deletion
+    bool        is_system = false; // if true, the customization is a system customization
 
     // used for removing from a list
     bool operator==(const AnalogCustomization & a) const {

src/web/WebDataService.cpp

@@ -143,6 +143,7 @@ void WebDataService::sensor_data(AsyncWebServerRequest * request) {
             obj["o"]       = sensor.offset();
             obj["f"]       = sensor.factor();
             obj["t"]       = sensor.type();
+            obj["s"]       = sensor.is_system();
 
             if (sensor.type() != AnalogSensor::AnalogType::NOTUSED) {
                 obj["v"] = Helpers::transformNumFloat(sensor.value()); // is optional and is a float