diff --git a/src/core/emsdevice.cpp b/src/core/emsdevice.cpp index ffba6f91e..3deebfd3c 100644 --- a/src/core/emsdevice.cpp +++ b/src/core/emsdevice.cpp @@ -1528,6 +1528,7 @@ bool EMSdevice::get_value_info(JsonObject output, const char * cmd, const int8_t if (cmd_s == Helpers::toLower(dv.short_name) && (tag <= 0 || tag == dv.tag)) { get_value_json(output, dv); // if we're filtering on an attribute, go find it + // if we can't find it, maybe it exists but doesn't not have a value assigned yet return Command::set_attribute(output, cmd_s, attribute_s); } } diff --git a/src/core/emsesp.cpp b/src/core/emsesp.cpp index 45ee17a62..f4b11df0d 100644 --- a/src/core/emsesp.cpp +++ b/src/core/emsesp.cpp @@ -780,6 +780,7 @@ bool EMSESP::get_device_value_info(JsonObject root, const char * cmd, const int8 } } } + // if the EMS device was valid, but the cmd not found exit. it will be handled upstream. if (found_device) { return false;