From fc0fd625d3f98bf4c832f8e938e9ab6436a92b3a Mon Sep 17 00:00:00 2001 From: proddy Date: Tue, 8 Oct 2024 22:52:05 +0200 Subject: [PATCH] show error when using an invalid gpio in webUI --- src/analogsensor.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/analogsensor.cpp b/src/analogsensor.cpp index 7b1703f54..1a3d48681 100644 --- a/src/analogsensor.cpp +++ b/src/analogsensor.cpp @@ -134,8 +134,8 @@ void AnalogSensor::reload(bool get_nvs) { // first check if the GPIO is valid. If not, force set it to disabled if (!System::is_valid_gpio(sensor.gpio())) { LOG_WARNING("Bad GPIO %d for Sensor %s. Disabling.", sensor.gpio(), sensor.name().c_str()); - sensor.set_type(AnalogType::NOTUSED); - continue; // skip this loop pass + sensor.set_type(AnalogType::NOTUSED); // set disabled + continue; // skip this loop pass } if (sensor.type() == AnalogType::ADC) { @@ -402,7 +402,9 @@ bool AnalogSensor::update(uint8_t gpio, std::string & name, double offset, doubl // reloads the sensors in the customizations file into the sensors list reload(); - return true; + // return false if it's an invalid GPIO, an error will show in WebUI + // and reported as an error in the log + return System::is_valid_gpio(gpio); } // check to see if values have been updated