andry/EMS-ESP32
1
0
Fork 0
mirror of https://github.com/emsesp/EMS-ESP32.git synced 2025-12-09 01:09:51 +03:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1840 from mheyse/fix/check-parameter-order

Browse Source 
fix: nullptr linter error
This commit is contained in:
Proddy
2024-07-04 10:02:31 +02:00
committed by GitHub
parent a0ca1ce87c 8c810f2276
commit 6b6224dead
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/modbus.cpp
View File

@@ -65,8 +65,10 @@ bool Modbus::check_parameter_order() {
for (const auto & mi : modbus_register_mappings) {
if (isFirst) {
isFirst = false;
} else if (prev == nullptr || !prev->isLessThan(mi)) {
// TODO fix nullptr dereference when printing
} else if (prev == nullptr) {
LOG_ERROR("Error checking modbus parameters %s.", mi.short_name);
return false;
} else if(!prev->isLessThan(mi)) {
LOG_ERROR("Error in modbus parameters: %s must be listed before %s.", mi.short_name, prev->short_name);
return false;
}